Hi Simon,
On Fri, Apr 28, 2017 at 7:14 AM, Simon Horman <horms@xxxxxxxxxxxx> wrote:
> On Wed, Apr 26, 2017 at 02:35:58PM +0200, Geert Uytterhoeven wrote:
>> On Wed, Apr 26, 2017 at 9:34 AM, Simon Horman <horms@xxxxxxxxxxxx> wrote:
>> > On Wed, Apr 26, 2017 at 09:13:06AM +0200, Simon Horman wrote:
>> >> On Tue, Apr 25, 2017 at 07:36:25PM +0200, Geert Uytterhoeven wrote:
>> >> > If the R-Car RST driver is not included, compile-testing R-Car clock
>> >> > drivers fails with a link error:
>> >> >
>> >> > undefined reference to `rcar_rst_read_mode_pins'
>> >> >
>> >> > To fix this, provide a dummy version. Use the exact same test logic as
>> >> > in drivers/soc/renesas/Makefile, as there is no Kconfig symbol (yet) to
>> >> > control compilation of the R-Car RST driver.
>> >>
>> >> Adding a Kconfig symbol would be a bit cleaner IMHO.
>> >
>> > I now see you are doing so in other patches :)
>>
>> Indeed. I went with this quick fix, as drivers/soc/renesas doesn't have
>> a Kconfig file yet, and introducing a Kconfig symbol would thus be more
>> intrusive.
>
> Thanks. Given that it doesn't appear that the problem resolved by this fix
> manifests at this time I have queued it up for v4.13 rather than as a fix
> for v4.12. Let me know if you'd like me to revisit that decision.
I had hoped you could still queue it as a fix for v4.12...
This is one of the blockers for enabling compile-testing of the R-Car clock
drivers in v4.13. Of course some of the other blockers may not make v4.12
neither.
Instead of postponing it to v4.13, you could as well drop it, and wait for
the better solution in "[RFC] soc: renesas: Rework Kconfig and Makefile
logic".
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
