Hi Geert, Simon, On Thu, Apr 27, 2017 at 10:42:02AM +0200, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Thu, Apr 27, 2017 at 10:19 AM, Jacopo Mondi > <jacopo+renesas@xxxxxxxxxx> wrote: > > this is 5th round of gpio/pincontroller for RZ/A1 devices. > > > > I have updated the pin controller driver to use the newly introduced > > "pinctrl_enable()" function. > > This is required since v4.11-rc7 as otherwise, as reported by Chris Brandt, > > the pin controller does not start. > > > > I have incorporated your comments on the device tree bindings documentation, > > and added to pinctrl-generic.h header file two macros to unpack generic > > properties and their arguments. > > > > Tested with SCIF, RIIC, ETHER and gpio-leds on Genmai board. > > Thanks for the update! > > > Jacopo Mondi (10): > > pinctrl: generic: Add bi-directional and output-enable > > Already applied by LinusW. > > > pinctrl: generic: Add macros to unpack properties > > LinusW: do you want me to queue this together with the driver for v4.13, > or will you take this single patch for v4.12? > > > pinctrl: Renesas RZ/A1 pin and gpio controller > > dt-bindings: pinctrl: Add RZ/A1 bindings doc > > Will queue in sh-pfc-for-v4.13. > > > arm: dts: dt-bindings: Add Renesas RZ/A1 pinctrl header > > arm: dts: r7s72100: Add pin controller node > > arm: dts: genmai: Add SCIF2 pin group > > arm: dts: genmai: Add RIIC2 pin group > > arm: dts: genmai: Add user led device nodes > > arm: dts: genmai: Add ethernet pin group > > These are for Simon. > > Does applying the DTS changes before the driver introduce regressions? > If no, Simon can queue them for v4.13. > If yes, they'll have to wait for v4.14. > I tried reverting patch [03/10] which introduces the driver, and I lose serial output on Genmai. So I guess the dts patches have to be taken after the driver has been merged. One question: why can't they be taken at the same time? (eg. for v4.13?) Thanks j > Thanks! > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds