Re: [PATCH] soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Simon,

On Wed, Apr 26, 2017 at 9:34 AM, Simon Horman <horms@xxxxxxxxxxxx> wrote:
> On Wed, Apr 26, 2017 at 09:13:06AM +0200, Simon Horman wrote:
>> On Tue, Apr 25, 2017 at 07:36:25PM +0200, Geert Uytterhoeven wrote:
>> > If the R-Car RST driver is not included, compile-testing R-Car clock
>> > drivers fails with a link error:
>> >
>> >     undefined reference to `rcar_rst_read_mode_pins'
>> >
>> > To fix this, provide a dummy version.  Use the exact same test logic as
>> > in drivers/soc/renesas/Makefile, as there is no Kconfig symbol (yet) to
>> > control compilation of the R-Car RST driver.
>>
>> Adding a Kconfig symbol would be a bit cleaner IMHO.
>
> I now see you are doing so in other patches :)

Indeed. I went with this quick fix, as drivers/soc/renesas doesn't have
a Kconfig file yet, and introducing a Kconfig symbol would thus be more
intrusive.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux