Re: [PATCH] soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 26, 2017 at 02:35:58PM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Wed, Apr 26, 2017 at 9:34 AM, Simon Horman <horms@xxxxxxxxxxxx> wrote:
> > On Wed, Apr 26, 2017 at 09:13:06AM +0200, Simon Horman wrote:
> >> On Tue, Apr 25, 2017 at 07:36:25PM +0200, Geert Uytterhoeven wrote:
> >> > If the R-Car RST driver is not included, compile-testing R-Car clock
> >> > drivers fails with a link error:
> >> >
> >> >     undefined reference to `rcar_rst_read_mode_pins'
> >> >
> >> > To fix this, provide a dummy version.  Use the exact same test logic as
> >> > in drivers/soc/renesas/Makefile, as there is no Kconfig symbol (yet) to
> >> > control compilation of the R-Car RST driver.
> >>
> >> Adding a Kconfig symbol would be a bit cleaner IMHO.
> >
> > I now see you are doing so in other patches :)
> 
> Indeed. I went with this quick fix, as drivers/soc/renesas doesn't have
> a Kconfig file yet, and introducing a Kconfig symbol would thus be more
> intrusive.

Thanks. Given that it doesn't appear that the problem resolved by this fix
manifests at this time I have queued it up for v4.13 rather than as a fix
for v4.12. Let me know if you'd like me to revisit that decision.



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux