RE: [PATCH v3 1/3] nvme-rdma: correctly check for target keyed sgl support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> >> you should add to your new code:
> >>
> >> diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
> >> index 2b6dc19..5828bf2 100644
> >> --- a/drivers/nvme/target/rdma.c
> >> +++ b/drivers/nvme/target/rdma.c
> >> @@ -964,7 +965,7 @@ static int nvmet_rdma_create_queue_ib(struct
> >> nvmet_rdma_queue *queue)
> >>           } else {
> >>                   /* +1 for drain */
> >>                   qp_attr.cap.max_recv_wr = 1 + queue->recv_queue_size;
> >> -               qp_attr.cap.max_recv_sge = 2;
> >> +               qp_attr.cap.max_recv_sge = 1 + ndev->inline_page_count;
> >>           }
> >>
> >>           ret = rdma_create_qp(queue->cm_id, ndev->pd, &qp_attr);
> >>
> >
> > Yes.  Good catch.
> >
> >>
> >>
> >> I currently see some timeout in the initiator also with 4k inline but
it
> >> works good with old initiator.
> >>
> >
> > This is with my github repo?
> 
> The initiator is from V3 here.
> Is there a difference in the initiator code ?

Just removing a pr_debug().


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux