Re: [PATCH v3 1/3] nvme-rdma: correctly check for target keyed sgl support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




I can see that the 2 and 20 are defined for specific things.  Since they are
used in several places (in the next 2 patches), is there any chance these
could be defined bits?

Mike

That seems reasonable.  I would think these defines could also be shared
across the host and target.  Perhaps include/linux/nvme.h?  I see both
nvme/host/nvme.h and nvme/target/nvmet.h include linux/nvme.h.  So they
could go there.

Christoph, what do you think?  It seems like these are either nvme
protocol bits or nvme/f protocol bits...

Steve.



It looks like these bits are part of the Identify Controller Data
Structure, figure 90 in the 1.2.1 spec.  The SGL Support (SGLS) field
within that struct.   So I guess it belongs in include/linux/nvme.h?
But I don't see any of this big structure in that header.


Yea, good idea, though please add the offset type sgl as well.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux