On Thu, May 31, 2018 at 12:37:33AM +0300, Sagi Grimberg wrote: >> It looks like these bits are part of the Identify Controller Data >> Structure, figure 90 in the 1.2.1 spec. The SGL Support (SGLS) field >> within that struct. So I guess it belongs in include/linux/nvme.h? >> But I don't see any of this big structure in that header. >> > > Yea, good idea, though please add the offset type sgl as well. Honestly, I'd rather keep defines for every little bit without a name out of the headers. The bit numbers will show up right there when looking for the field in the nvme spec, while making up our own names will just create confusion. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
