On Tue, May 29, 2018 at 08:23:09PM +0000, Ruhl, Michael J wrote: > I can see that the 2 and 20 are defined for specific things. Since they are > used in several places (in the next 2 patches), is there any chance these > could be defined bits? So far our rule of thumb was to use defines where the NVMe spec defines symbolic names, and use plain bit numbers where the spec does the same. The SGLS field falls into the latter category. If we end up with a lot of users a little helper function might be nice, but I don't think we aren't there yet. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
