> -----Original Message----- > From: Sagi Grimberg <sagi@xxxxxxxxxxx> > Sent: Sunday, June 3, 2018 6:57 AM > To: hch@xxxxxx; Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx> > Cc: Ruhl, Michael J <michael.j.ruhl@xxxxxxxxx>; axboe@xxxxxxxxx; Busch, > Keith <keith.busch@xxxxxxxxx>; linux-nvme@xxxxxxxxxxxxxxxxxxx; > parav@xxxxxxxxxxxx; maxg@xxxxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v3 1/3] nvme-rdma: correctly check for target keyed sgl > support > > > >> Ok then, I will leave them as bit numbers... > > > > Btw, modulo the debug printk 1 & 2 look fine to me and I'd like to > > pull them in. Sagi, are you ok with the patches? > > I'd like to see a version that avoids higher order allocations first > as we can have a non negligible number of these allocations. > If it turns out too much of hassle we can stay with this. He's referring to patch 1 and 2, which are the host side. No page allocations. Also, I made the changes to avoid higher order allocations for patch 3. Testing now. I'll send it out tomorrow. Steve. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html