On 9/16/2016 12:34 PM, Doug Ledford wrote:
> On 9/16/2016 12:16 PM, Jason Gunthorpe wrote:
>> On Fri, Sep 16, 2016 at 11:12:17AM -0400, Doug Ledford wrote:
>>
>>> I would. Mainly because it is tied to both the kernel uAPI (via
>>> netlink)and to librdmacm
>>
>> With what little I know about ibacm I'm inclined to agree. It seems
>> like a utility for librdmacm, and is consuming a kernel interface.
>>
>> Reconsider Sean?
>>
>>> (such that librdmacm changes how it builds when ibacm is present, so
>>> if we don't include it, then ibacm becomes a requirement of the
>>> larger package if you want librdmacm to support the ibacm cache
>>> service).
>>
>> I double checked and I couldn't find anything like
>> this. librdmacm/src/amc.c builds unconditionally and contains no
>> ifdefs, configure does not key on anything to do with acm.
>
> Sorry, must have changed. It used to do so (configure used to test for
> presence of ibacm header file and change compile settings accordingly as
> I recall).
Yes, you recall correctly; this change is in librdmacm 1.0.18 and beyond:
commit c8be3cfde6902e490fadd6a51206c1bcba3e3aa2
Author: Sean Hefty <sean.hefty@xxxxxxxxx>
Date: Mon Jun 10 10:57:56 2013 -0700
init: Remove USE_IB_ACM configuration option
When the librdmacm is configured, it sets the USE_IB_ACM option
if infininband/acm.h is found. We can remove this option with
very little overhead, which would allow a user to install
ACM after installing the librdmacm, and the librdmacm would be
able to make use of ACM.
Signed-off-by: Sean Hefty <sean.hefty@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
