On Sat, Apr 18, 2009 at 12:56:34AM -0700, Yinghai Lu wrote: > 1. put the calling in pci_create_bus, archs other than x86 will have > blank weak function > 2. if put that calling in pci_scan_child_bus, will make every child bus > do that checking on x86 platform. > > other arch does not gain anything in final result Having x86 do its PCI fixups somewhere different from every other arch is confusing. I know this because it confused me. This isn't about saving a couple of hundred cycles at boot time, it's about maintainability. > on x86 it will keep on calling set_pci_bus_resources_arch_default for every bus in addition to root bus. > because pci_scan_child_bus is called for all buses, and pci_create_bus is only for root bus. > > YH -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
