Ingo Molnar wrote: > * Matthew Wilcox <matthew@xxxxxx> wrote: > > >> Commit 30a18d6c3f1e774de656ebd8ff219d53e2ba4029 introduced a new >> function to set the PCI bus resources. Unfortunately, neither the >> author, nor the committers seemed to know that we already have >> somewhere to do that -- pcibios_fixup_bus(). This patch moves the >> hook (used only by the K8 code) into x86-specific code where it >> should have been in the first place. >> > > That's one scary commit! > > Thanks for cleaning this up. > > Acked-by: Ingo Molnar <mingo@xxxxxxx> > > A better name for the callback would be x86_pci_root_bus_quirks() ? > ok, back to this thread. pci_create_bus is only for root bus, and pci_scan_child_bus is called on that root bus. if we moved x86_pci_root_bus_res_quirks calling in pci_scan_child_bus, it will be checked with all child buses. so we'd better to keep that calling in pci_create_bus. YH -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
