Re: [PATCH] Move set_pci_bus_resources_arch_default into arch/x86

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 17, 2009 at 02:45:55PM -0700, Yinghai Lu wrote:
> Matthew Wilcox wrote:
> > On Fri, Apr 17, 2009 at 02:25:13PM -0700, Yinghai Lu wrote:
> >> if we moved x86_pci_root_bus_res_quirks calling in pci_scan_child_bus,
> >> it will be checked with all child buses.
> >>
> >> so we'd better to keep that calling in pci_create_bus.
> >
> > But set_pci_bus_resources_arch_default() already checks that it's being
> > called for a root bus:
>
> We should have a better name for pci_create_bus and
> set_pci_bus_resources_arch_default
> like pci_create_root_bus and set_root_bus_res_arch.

The naming is orthogonal to this patch.  Please withdraw your nacked-by.

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux