Matthew Wilcox wrote: > On Fri, Apr 17, 2009 at 02:45:55PM -0700, Yinghai Lu wrote: > >> Matthew Wilcox wrote: >> >>> On Fri, Apr 17, 2009 at 02:25:13PM -0700, Yinghai Lu wrote: >>> >>>> if we moved x86_pci_root_bus_res_quirks calling in pci_scan_child_bus, >>>> it will be checked with all child buses. >>>> >>>> so we'd better to keep that calling in pci_create_bus. >>>> >>> But set_pci_bus_resources_arch_default() already checks that it's being >>> called for a root bus: >>> >> We should have a better name for pci_create_bus and >> set_pci_bus_resources_arch_default >> like pci_create_root_bus and set_root_bus_res_arch. >> > > The naming is orthogonal to this patch. Please withdraw your nacked-by. > > 1. put the calling in pci_create_bus, archs other than x86 will have blank weak function 2. if put that calling in pci_scan_child_bus, will make every child bus do that checking on x86 platform. other arch does not gain anything in final result on x86 it will keep on calling set_pci_bus_resources_arch_default for every bus in addition to root bus. because pci_scan_child_bus is called for all buses, and pci_create_bus is only for root bus. YH -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
