"Hiremath, Vaibhav" <hvaibhav@xxxxxx> writes:
>> >>> +static struct omap_hwmod am33xx_debugss_hwmod = {
>> >>> + .name = "debugss",
>> >>> + .class = &am33xx_debugss_hwmod_class,
>> >>> + .clkdm_name = "l3_aon_clkdm",
>> >>> + .main_clk = "debugss_ick",
>> >>> + .flags = (HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET),
>>
>> Setting these flags would still leave the problem where JTAG clocks
>> are on when its not required no? In that case, what is the advantage
>> of this patch?
>>
>
> I missed to wrap it around #ifdef CONFIG_DEBUG_KERNEL. I will submit the
> formal patch shortly.
IMO, this should not be handled in the data at all (neither clock nor
hwmod), and should be handled at runtime/boot-time, not compile time.
The solution to this is to rather to have a small bit of code that
requests the debugss clocks that are needed for JTAG debug, so the
kernel knows they are in use.
That code could then be enabled at boot time via command-line or DT
option.
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
