Re: AM335x: Beaglebone stops to boot with current git kernel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, Nov 14, 2012 at 4:28 PM, Igor Mazanov <i.mazanov@xxxxxxxxx> wrote:
> Hello,
>
> Beaglebone boot process is broken with the current git kernel. I use
> omap2plus_defconfig for tests.
>
> It looks like the boot process stops due to the last changes in the AM33xx
> clock sysbsystem. A following patch resolves this issue:
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> index ad8d43b..858e180 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> @@ -586,7 +586,7 @@ static struct omap_hwmod am33xx_smartreflex0_hwmod = {
>         .class          = &am33xx_smartreflex_hwmod_class,
>         .clkdm_name     = "l4_wkup_clkdm",
>         .mpu_irqs       = am33xx_smartreflex0_irqs,
> -       .main_clk       = "smartreflex0_fck",
> +       .main_clk       = "smartreflex_mpu_fck",
>         .prcm           = {
>                 .omap4  = {
>                         .clkctrl_offs   =
> AM33XX_CM_WKUP_SMARTREFLEX0_CLKCTRL_OFFSET,
> @@ -606,7 +606,7 @@ static struct omap_hwmod am33xx_smartreflex1_hwmod = {
>         .class          = &am33xx_smartreflex_hwmod_class,
>         .clkdm_name     = "l4_wkup_clkdm",
>         .mpu_irqs       = am33xx_smartreflex1_irqs,
> -       .main_clk       = "smartreflex1_fck",
> +       .main_clk       = "smartreflex_core_fck",
>         .prcm           = {
>                 .omap4  = {
>                         .clkctrl_offs   =
> AM33XX_CM_WKUP_SMARTREFLEX1_CLKCTRL_OFFSET,
>

About the name field in the hwmod entry: the SR code checks on the
value of "smartreflex_mpu_iva" to differentiate the SR IP blocks and
to apply the correct parameters to each of them. Cf. the function
sr_set_regfields in drivers/power/avs/smartreflex.c.

The patch should change the name of the hwmod entry as well, can you
fold this change in the current patch?

Note: I know the name "smartreflex_mpu_iva" is not perfect since it
does not apply to all OMAP3 variants, maybe we could change the SR
code to be more generic.

Nishant, what do you think?

Regards,
Jean

>
> Regards,
> Igor.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux