* Mohammed, Afzal <afzal@xxxxxx> [120614 03:43]: > Hi Tony, > > On Thu, Jun 14, 2012 at 15:49:02, Tony Lindgren wrote: > > > Well I took a look at the values, and it seems the only difference is the > > static GPMC_CONFIG1_CLKACTIVATIONTIME(1) that your patch now overwrites 0. > > It seems change below should be part of $subject. > > Please let me know your comments Well I could not get this to apply either on top of the $subject nor all your patches for some reason, but I manually applied the tusb6010 part with the following change.. > --- a/arch/arm/mach-omap2/usb-tusb6010.c > +++ b/arch/arm/mach-omap2/usb-tusb6010.c > @@ -174,6 +174,8 @@ static int tusb_set_sync_mode(unsigned sysclk_ps, unsigned fclk_ps) > tmp = t.cs_wr_off * 1000 + 7000 /* t_scsn_rdy_z */; > t.wr_cycle = next_clk(t.cs_wr_off, tmp, fclk_ps); > > + t.clk_activation = gpmc_ticks_to_ns(1); > + ..this should be just 1 as it's one tick, not ns. > return gpmc_cs_set_timings(sync_cs, &t); > } > > @@ -283,7 +285,6 @@ tusb6010_setup_interface(struct musb_hdrc_platform_data *data, > | GPMC_CONFIG1_READTYPE_SYNC > | GPMC_CONFIG1_WRITEMULTIPLE_SUPP > | GPMC_CONFIG1_WRITETYPE_SYNC > - | GPMC_CONFIG1_CLKACTIVATIONTIME(1) > | GPMC_CONFIG1_PAGE_LEN(2) > | GPMC_CONFIG1_WAIT_READ_MON > | GPMC_CONFIG1_WAIT_WRITE_MON And that makes tusb6010 work as earlier with your patches. For onenand I'm getting the following error: omap2-onenand omap2-onenand: Cannot request GPMC CS Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
