On Tue, 15 Feb 2011 16:08:32 +0200 David Cohen <dacohen@xxxxxxxxx> wrote: > > So it's sure that a developer won't need these error dumps when > > receiving an error report? I.e. IOMMU upper level errors give enough > > information to start doing own debugging? > > Yes, developers do need this information. > But it's a bit useless tell only we've got an iommu fault, due to many > places might be causing it. My purpose is to let the debug > responsibility to IOMMU users. They have access to the iovmm layer as > well and can provide a much more useful information. > e.g. OMAP3 ISP has many submodules using IOMMU. With a fault callback, > it can dump all the iovm areas and the faulty 'da' too. It might > indicate which submodule was responsible for the issue. > > Of course we can just let this debug messages the way they are and > print this redundant information. But IMO it's not necessary. > Sounds fair enough and if I understood correctly this is not something what end user will hit but more like another developer. In that case the debug messages are the right thing. -- Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
