On Tue, Feb 15, 2011 at 3:38 PM, Sergei Shtylyov <sshtylyov@xxxxxxxxxx> wrote:
> Hello.
Hi,
>
> On 15-02-2011 16:20, David Cohen wrote:
>
>> IOMMU upper layer is already printing error message. OMAP2+ specific
>> layer may print error message only for debug purpose.
>
>> Signed-off-by: David Cohen<dacohen@xxxxxxxxx>
>> ---
>> Âarch/arm/mach-omap2/iommu2.c | Â Â6 +++---
>> Â1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/iommu2.c b/arch/arm/mach-omap2/iommu2.c
>> index 14ee686..4244a07 100644
>> --- a/arch/arm/mach-omap2/iommu2.c
>> +++ b/arch/arm/mach-omap2/iommu2.c
>> @@ -163,13 +163,13 @@ static u32 omap2_iommu_fault_isr(struct iommu *obj,
>> u32 *ra)
>> Â Â Â Âda = iommu_read_reg(obj, MMU_FAULT_AD);
>> Â Â Â Â*ra = da;
>>
>> - Â Â Â dev_err(obj->dev, "%s:\tda:%08x ", __func__, da);
>> + Â Â Â dev_dbg(obj->dev, "%s:\tda:%08x ", __func__, da);
>
> Â Note that dev_dbg() will only print something if either DEBUG or
> CONFIG_DYNAMIC_DEBUG are defined...
That's my plan.
>
>>
>> Â Â Â Âfor (i = 0; i< ÂARRAY_SIZE(err_msg); i++) {
>> Â Â Â Â Â Â Â Âif (stat & (1<< Âi))
>> - Â Â Â Â Â Â Â Â Â Â Â printk("%s ", err_msg[i]);
>> + Â Â Â Â Â Â Â Â Â Â Â printk(KERN_DEBUG "%s ", err_msg[i]);
>
> Â ... unlike printk(KERN_DEBUG...). You probably want to use pr_debug()
> instead.
>
>> Â Â Â Â}
>> - Â Â Â printk("\n");
>> + Â Â Â printk(KERN_DEBUG "\n");
>
> Â Here too... Although wait, it should be KERN_CONT instead! Debug levels
> are only attributed to the whole lines.
But your observation is correct. I'll resend it with KERN_CONT instead.
Regards,
David
>
> WBR, Sergei
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
