On Tue, Feb 15, 2011 at 4:29 PM, Russell King - ARM Linux
<linux@xxxxxxxxxxxxxxxx> wrote:
> On Tue, Feb 15, 2011 at 04:38:32PM +0300, Sergei Shtylyov wrote:
>>> diff --git a/arch/arm/mach-omap2/iommu2.c b/arch/arm/mach-omap2/iommu2.c
>>> index 14ee686..4244a07 100644
>>> --- a/arch/arm/mach-omap2/iommu2.c
>>> +++ b/arch/arm/mach-omap2/iommu2.c
>>> @@ -163,13 +163,13 @@ static u32 omap2_iommu_fault_isr(struct iommu *obj, u32 *ra)
>>> Â Â Âda = iommu_read_reg(obj, MMU_FAULT_AD);
>>> Â Â Â*ra = da;
>>>
>>> - Â Âdev_err(obj->dev, "%s:\tda:%08x ", __func__, da);
>>> + Â Âdev_dbg(obj->dev, "%s:\tda:%08x ", __func__, da);
>>
>> Â ÂNote that dev_dbg() will only print something if either DEBUG or
>> CONFIG_DYNAMIC_DEBUG are defined...
>>
>>>
>>> Â Â Âfor (i = 0; i< ÂARRAY_SIZE(err_msg); i++) {
>>> Â Â Â Â Â Â Âif (stat & (1<< Âi))
>>> - Â Â Â Â Â Â Â Â Â Âprintk("%s ", err_msg[i]);
>>> + Â Â Â Â Â Â Â Â Â Âprintk(KERN_DEBUG "%s ", err_msg[i]);
>>
>> Â Â... unlike printk(KERN_DEBUG...). You probably want to use pr_debug() instead.
>
> No - this isn't starting a new line. Âpr_cont() here.
But pr_cont() would be wrong in case of DEBUG isn't set, isn't it?
>
>>> Â Â Â}
>>> - Â Âprintk("\n");
>>> + Â Âprintk(KERN_DEBUG "\n");
>>
>> Â ÂHere too... Although wait, it should be KERN_CONT instead! Debug
>> levels are only attributed to the whole lines.
>
> And pr_cont() here too. ÂIf you care about using KERN_CONT which is
> just a static marker to allow automated printk level checking easier.
The same situation here.
But this patch was dropped in the next version.
Br,
David
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
