> -----Original Message----- > From: Santosh Shilimkar [mailto:santosh.shilimkar@xxxxxx] > Sent: Wednesday, January 05, 2011 12:18 AM > To: Nishanth Menon > Cc: linux-omap@xxxxxxxxxxxxxxx; Kevin Hilman; tony@xxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Thara Gopinath; Kevin Hilman > Subject: RE: [PATCH 4/5] omap2plus: voltage: Trivial linking fix > 'undefined reference' > > > -----Original Message----- > > From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- > > owner@xxxxxxxxxxxxxxx] On Behalf Of Nishanth Menon > > Sent: Wednesday, January 05, 2011 12:16 AM > > To: Santosh Shilimkar > > Cc: linux-omap@xxxxxxxxxxxxxxx; khilman@xxxxxx; tony@xxxxxxxxxxx; > > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Thara Gopinath; Kevin Hilman > > Subject: Re: [PATCH 4/5] omap2plus: voltage: Trivial linking fix > > 'undefined reference' > > > > Santosh Shilimkar had written, on 01/04/2011 12:26 PM, the > > following: > > [..] > > [..] > > > +static inline struct voltagedomain > > *omap_voltage_domain_lookup(char *name) > > > +{ > > > + return NULL; > > the omap_voltage_domain_lookup uses ERR_PTR() for all return > values > > which are handled by the callers with IS_ERR() > > > > I think you should return ERR_PTR(-EINVAL) > > > The expected return value is pointer type and hence used > NULL. 'ERR_PTR(-EINVAL)' is also ok. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
