> -----Original Message----- > From: Nishanth Menon [mailto:nm@xxxxxx] > Sent: Wednesday, January 05, 2011 12:19 AM > To: Santosh Shilimkar > Cc: linux-omap@xxxxxxxxxxxxxxx; khilman@xxxxxx; tony@xxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Thara Gopinath; Kevin Hilman > Subject: Re: [PATCH 5/5] omap2plus: voltage: Trivial linking fix for > 'EINVAL' undeclared > > Santosh Shilimkar had written, on 01/04/2011 12:26 PM, the > following: > > CC arch/arm/mach-omap2/omap_hwmod_common_data.o > > In file included from arch/arm/plat- > omap/include/plat/omap_hwmod.h:38, > > from arch/arm/mach- > omap2/omap_hwmod_common_data.c:20: > > arch/arm/plat-omap/include/plat/voltage.h: In function > 'omap_voltage_late_init': > > arch/arm/plat-omap/include/plat/voltage.h:145: error: 'EINVAL' > undeclared (first use in this function) > > arch/arm/plat-omap/include/plat/voltage.h:145: error: (Each > undeclared identifier is reported only once > > arch/arm/plat-omap/include/plat/voltage.h:145: error: for each > function it appears in.) > > make[1]: *** [arch/arm/mach-omap2/omap_hwmod_common_data.o] Error > 1 > > make: *** [arch/arm/mach-omap2] Error 2 > > > > The error is reported when omap2plus_defconfig built with > CONFIG_PM disabled > > > > Signed-off-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx> > > Cc: Thara Gopinath <thara@xxxxxx> > > Cc: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> > > --- > > arch/arm/plat-omap/include/plat/voltage.h | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/plat-omap/include/plat/voltage.h > b/arch/arm/plat-omap/include/plat/voltage.h > > index c095351..2b776f0 100644 > > --- a/arch/arm/plat-omap/include/plat/voltage.h > > +++ b/arch/arm/plat-omap/include/plat/voltage.h > > @@ -14,6 +14,8 @@ > > #ifndef __ARCH_ARM_MACH_OMAP2_VOLTAGE_H > > #define __ARCH_ARM_MACH_OMAP2_VOLTAGE_H > > > > +#include <linux/err.h> > > + > > Not sure if this is better OR including the err.h in c files is > better, > since the c file is the location where the error code is actually > used.. > > but no strong feelings about either personally. > The error is because of 'EINVAL' usage in header file. How Will this error get fixed by including err.h is C file ? -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
