> -----Original Message----- > From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- > owner@xxxxxxxxxxxxxxx] On Behalf Of Nishanth Menon > Sent: Wednesday, January 05, 2011 12:16 AM > To: Santosh Shilimkar > Cc: linux-omap@xxxxxxxxxxxxxxx; khilman@xxxxxx; tony@xxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Thara Gopinath; Kevin Hilman > Subject: Re: [PATCH 4/5] omap2plus: voltage: Trivial linking fix > 'undefined reference' > > Santosh Shilimkar had written, on 01/04/2011 12:26 PM, the > following: > [..] > > > diff --git a/arch/arm/plat-omap/include/plat/voltage.h > b/arch/arm/plat-omap/include/plat/voltage.h > > index 710f4ea..c095351 100644 > > --- a/arch/arm/plat-omap/include/plat/voltage.h > > +++ b/arch/arm/plat-omap/include/plat/voltage.h > > @@ -65,9 +65,6 @@ struct voltagedomain { > > char *name; > > }; > > > > -/* API to get the voltagedomain pointer */ > > -struct voltagedomain *omap_voltage_domain_lookup(char *name); > > - > > /** > > * struct omap_volt_data - Omap voltage specific data. > > * @voltage_nominal: The possible voltage value in uV > > @@ -131,6 +128,9 @@ int omap_voltage_register_pmic(struct > voltagedomain *voltdm, > > struct omap_volt_pmic_info *pmic_info); > > void omap_change_voltscale_method(struct voltagedomain *voltdm, > > int voltscale_method); > > +/* API to get the voltagedomain pointer */ > > +struct voltagedomain *omap_voltage_domain_lookup(char *name); > > + > > int omap_voltage_late_init(void); > > #else > > static inline int omap_voltage_register_pmic(struct voltagedomain > *voltdm, > > @@ -144,6 +144,10 @@ static inline int > omap_voltage_late_init(void) > > { > > return -EINVAL; > > } > > +static inline struct voltagedomain > *omap_voltage_domain_lookup(char *name) > > +{ > > + return NULL; > the omap_voltage_domain_lookup uses ERR_PTR() for all return values > which are handled by the callers with IS_ERR() > > I think you should return ERR_PTR(-EINVAL) > The expected return value is pointer type and hence used NULL. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
