> -----Original Message----- > From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- > owner@xxxxxxxxxxxxxxx] On Behalf Of Nishanth Menon > Sent: Wednesday, January 05, 2011 12:14 AM > To: Santosh Shilimkar > Cc: linux-omap@xxxxxxxxxxxxxxx; khilman@xxxxxx; tony@xxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Thara Gopinath; Kevin Hilman > Subject: Re: [PATCH 3/5] omap2plus: voltage: Trivial warning fix 'no > return statement' > > Santosh Shilimkar had written, on 01/04/2011 12:26 PM, the > following: > [..] > > diff --git a/arch/arm/plat-omap/include/plat/voltage.h > b/arch/arm/plat-omap/include/plat/voltage.h > > index 0ff1233..710f4ea 100644 > > --- a/arch/arm/plat-omap/include/plat/voltage.h > > +++ b/arch/arm/plat-omap/include/plat/voltage.h > > @@ -134,7 +134,10 @@ void omap_change_voltscale_method(struct > voltagedomain *voltdm, > > int omap_voltage_late_init(void); > > #else > > static inline int omap_voltage_register_pmic(struct voltagedomain > *voltdm, > > - struct omap_volt_pmic_info *pmic_info) {} > > + struct omap_volt_pmic_info *pmic_info) > > +{ > > + return 0; > since we dont really succeed registering the pmic to voltage layer, > return -EINVAL? > Ok. Will take this in v2 Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
