ext Trilok Soni wrote:
Hi Hans,
Hello, Hans and Soni!
2) The Kconfig is probably missing a ARCH_OMAP dependency (sounds
reasonable, at least), so now it also compiles for the i686 but that
architecture doesn't have a clk_get function.
It *might* be possible that the same camera block would be used in
non-OMAP CPUs as well but I guess it is safe to assume that it depends
on ARCH_OMAP now.
4) I get a bunch of compile warnings (admittedly when compiling for
i686) that you might want to look at. Compiled against the 2.6.27
kernel with gcc-4.3.1. It might be bogus since I didn't compile for the
omap architecture.
I will update my toolchain to gcc-4.3.x for ARM and see if it
generates the warnings like below. But I think we are fine once we add
ARCH_OMAP dependency to this driver.
Thanks for the review comments. I will resubmit the patch.
Is this exactly the same code that was removed from linux-omap a while ago?
---
commit ebdae9abf598ae8a3ee1c8c477138f82b40e7809
Author: Tony Lindgren <tony@xxxxxxxxxxx>
Date: Mon Oct 27 13:33:13 2008 -0700
REMOVE OMAP LEGACY CODE: Delete all old omap specific v4l drivers
All v4l development must be done on the v4l mailing list with
linux-omap
list cc'd.
Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
---
Although I haven't had time to discuss this anywhere, I though a
possible reason of for the removal was that some parts of the code are
not that pretty (e.g. DMA) and those parts should be rewritten.
But yes, the OMAP 2 camera driver does actually work and I would suppose
it has users, too (think N800/N810).
I'm in if the aim is to get this back to linux-omap. :-) (Waiting for
the next patch from Trilok.)
Cheers,
--
Sakari Ailus
sakari.ailus@xxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
