Hi Hans, > > 1) The makefile isn't right: it compiles omap24xxcam.c and > omap24xxcam-dma.c as two modules, but I suspect you want only one since > the symbols that omap24xxcam.c needs from omap24xxcam-dma.c are not > exported. See e.g. the msp3400 driver in the Makefile for how to do it. I will make this change. > > 2) The Kconfig is probably missing a ARCH_OMAP dependency (sounds > reasonable, at least), so now it also compiles for the i686 but that > architecture doesn't have a clk_get function. I will add this dependency. > > 3) I was wondering whether Sakari also wants to add a Signed-off-by > line? Looking at the comments it seems that he was involved as well. I CCed from the first e-mail, so that he can review and give Signed-off-by to this patch. > > 4) I get a bunch of compile warnings (admittedly when compiling for > i686) that you might want to look at. Compiled against the 2.6.27 > kernel with gcc-4.3.1. It might be bogus since I didn't compile for the > omap architecture. I will update my toolchain to gcc-4.3.x for ARM and see if it generates the warnings like below. But I think we are fine once we add ARCH_OMAP dependency to this driver. Thanks for the review comments. I will resubmit the patch. -- ---Trilok Soni http://triloksoni.wordpress.com http://www.linkedin.com/in/triloksoni -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
