On Wednesday 26 November 2008 19:44:51 Trilok Soni wrote: > This patch was living at linux-omap GIT tree from long time and seem > to survive the testing. It is also used in N800/N810 Internet Tablet. > Sakari Ailus can give more information about this. I am not able to > submit this patch as inline one due to my git-send-email > configuration with Gmail. Hi Trilok, I found a few problems with this patch: 1) The makefile isn't right: it compiles omap24xxcam.c and omap24xxcam-dma.c as two modules, but I suspect you want only one since the symbols that omap24xxcam.c needs from omap24xxcam-dma.c are not exported. See e.g. the msp3400 driver in the Makefile for how to do it. 2) The Kconfig is probably missing a ARCH_OMAP dependency (sounds reasonable, at least), so now it also compiles for the i686 but that architecture doesn't have a clk_get function. 3) I was wondering whether Sakari also wants to add a Signed-off-by line? Looking at the comments it seems that he was involved as well. 4) I get a bunch of compile warnings (admittedly when compiling for i686) that you might want to look at. Compiled against the 2.6.27 kernel with gcc-4.3.1. It might be bogus since I didn't compile for the omap architecture. CC [M] /home/hans/work/src/v4l/v4l-dvb/v4l/omap24xxcam.o In file included from /home/hans/work/src/v4l/v4l-dvb/v4l/omap24xxcam.c:42: /home/hans/work/src/v4l/v4l-dvb/v4l/omap24xxcam.h: In function 'omap24xxcam_reg_in': /home/hans/work/src/v4l/v4l-dvb/v4l/omap24xxcam.h:549: warning: passing argument 1 of 'readl' makes pointer from integer without a cast /home/hans/work/src/v4l/v4l-dvb/v4l/omap24xxcam.h: In function 'omap24xxcam_reg_out': /home/hans/work/src/v4l/v4l-dvb/v4l/omap24xxcam.h:555: warning: passing argument 2 of 'writel' makes pointer from integer without a cast /home/hans/work/src/v4l/v4l-dvb/v4l/omap24xxcam.h: In function 'omap24xxcam_reg_merge': /home/hans/work/src/v4l/v4l-dvb/v4l/omap24xxcam.h:563: warning: passing argument 1 of 'readl' makes pointer from integer without a cast /home/hans/work/src/v4l/v4l-dvb/v4l/omap24xxcam.h:565: warning: passing argument 2 of 'writel' makes pointer from integer without a cast CC [M] /home/hans/work/src/v4l/v4l-dvb/v4l/omap24xxcam-dma.o In file included from /home/hans/work/src/v4l/v4l-dvb/v4l/omap24xxcam-dma.c:32: /home/hans/work/src/v4l/v4l-dvb/v4l/omap24xxcam.h: In function 'omap24xxcam_reg_in': /home/hans/work/src/v4l/v4l-dvb/v4l/omap24xxcam.h:549: warning: passing argument 1 of 'readl' makes pointer from integer without a cast /home/hans/work/src/v4l/v4l-dvb/v4l/omap24xxcam.h: In function 'omap24xxcam_reg_out': /home/hans/work/src/v4l/v4l-dvb/v4l/omap24xxcam.h:555: warning: passing argument 2 of 'writel' makes pointer from integer without a cast /home/hans/work/src/v4l/v4l-dvb/v4l/omap24xxcam.h: In function 'omap24xxcam_reg_merge': /home/hans/work/src/v4l/v4l-dvb/v4l/omap24xxcam.h:563: warning: passing argument 1 of 'readl' makes pointer from integer without a cast /home/hans/work/src/v4l/v4l-dvb/v4l/omap24xxcam.h:565: warning: passing argument 2 of 'writel' makes pointer from integer without a cast /home/hans/work/src/v4l/v4l-dvb/v4l/omap24xxcam-dma.c: In function 'omap24xxcam_dma_hwinit': /home/hans/work/src/v4l/v4l-dvb/v4l/omap24xxcam-dma.c:357: warning: passing argument 1 of '_spin_lock_irqsave' discards qualifiers from pointer target type /home/hans/work/src/v4l/v4l-dvb/v4l/omap24xxcam-dma.c:361: warning: passing argument 1 of '_spin_unlock_irqrestore' discards qualifiers from pointer target type Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
