RE: [PATCH 00/11] OMAP3 CPUidle patches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > It is not so clear if gpio that hack is even needed on OMAP3.  There
> is some warning about spurious interrupts when going to RET/OFF for
> OMAP2. I don't recall for OMAP3.  didn't those prepare functions dink
> with wake up masks in fear of spurious interrupts.  So, wasn't the
> result for you the opposite, it kept you from waking, instead of
> suppressing extra wakes?
> >
> > Did you fix the OMAP2 GPIO wakeup mask in use at least?  The code
> > had a hardcoded mask based on OMAP2 wakeup capable gpios which don't
> > apply to omap3.
>
> No I haven't modified that code. I have begun to use it before
> retention because it is under #if defined(CONFIG_ARCH_OMAP34XX)
> statement and used in case of omap2. Maybe we could stop using it in
> case of omap3 at least this comment in gpio.c supports this: "See
> OMAP2420 Errata item 1.101"? Seems to be just legacy code from omap2.

Yes, that section needs to be reworked.  It was probably the root cause of your failure.

Regards,
Richard W.

��.n��������+%������w��{.n�����{�������ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux