Re: [PULL REQUEST] Manpage and misc updates (try #2)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Robby Workman wrote:
> On Wed, 6 May 2009, Mike Frysinger wrote:
>
>> On Wednesday 06 May 2009 04:37:20 Alan Jenkins wrote:
>>> Mike Frysinger wrote:
>>>> ideally, genereate-modprobe.conf should go away, but there are still
>>>> packages out there that only do /etc/modules.d/.  if we assume distros
>>>> are taking care of them to convert to modprobe.d/, then no, we no
>>>> longer
>>>> need generate- modprobe.conf.  Gentoo has converted most packages, but
>>>> there's still a small handful left ...
>>>
>>> That's interesting to know.  If it's still being used for development
>>> but not migrating live systems, there might be reasons to keep it - but
>>> we could still strip out all the references to it from the
>>> documentation.
>>
>> how about:
>> - include it in tarball but stop installing it
>> - stop mentioning it in documentation
>> - add note to NEWS or whatever about it being long overdue for
>> deprecation
>> - stop mentioning modules.* beyond a historical foot note in the
>> modprobe.*
>> pages
>
> This sounds reasonable to me; I'll make a note in NEWS for try #3
> patchset.
>
>> - have `modprobe` whine when it sees modprobe.*
>

Like this?  If you approve I will add your "Reviewed-by:", since I've
not come across this issue myself.

--->

modprobe: whine about /etc/modules.* (old modutils configuration)

Apparently some distribution packages haven't heard the good news.

diff --git a/modprobe.c b/modprobe.c
index c2d0ef6..0b6afc2 100644
--- a/modprobe.c
+++ b/modprobe.c
@@ -1221,6 +1221,14 @@ static void parse_toplevel_config(const char *filename,
 		return;
 	}
 
+	if (access("/etc/modules.conf", F_OK) == 0)
+		warn("Old config file /etc/modules.conf is ignored, "
+		      "remove it or convert it to /etc/modprobe.d/.\n");
+
+	if (access("/etc/modules.d/", F_OK) == 0)
+		warn("Old config directory /etc/modules.d/ is ignored, "
+		      "remove it or convert it to /etc/modprobe.d/.\n");
+
 	/* deprecated config file */
 	if (parse_config_file("/etc/modprobe.conf", name, dump_only, removing,
 			      options, commands, aliases, blacklist) > 0)


--
To unsubscribe from this list: send the line "unsubscribe linux-modules" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux