On Thu, Oct 17, 2019 at 01:16:00PM +1100, Benjamin Herrenschmidt wrote: > On Tue, 2019-10-15 at 15:44 +0200, Ulf Hansson wrote: > > > Hmm, so it looks like PowerPC doesn't mark devices that are dma > > > coherent with a property that describes them as such. > > > > > > I think this opens a wider question - what should > > > of_dma_is_coherent() > > > return for PowerPC? It seems right now that it returns false for > > > devices that are DMA coherent, which seems to me to be a recipe for > > > future mistakes. > > > > Perhaps implement the arch_setup_dma_ops() for PPC, that set > > "dev->dma_coherent = true" could work? > > Only for coherent ops :) For those of us who have never touched the PowerPC code before, any suggestion where you would like to see that? No file in arch/powerpc/mm stands out as a place for DMA stuff (and dma-noncoherent.c is certainly not correct.) Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up
