On Tue, 2019-10-15 at 15:44 +0200, Ulf Hansson wrote: > > Hmm, so it looks like PowerPC doesn't mark devices that are dma > > coherent with a property that describes them as such. > > > > I think this opens a wider question - what should > > of_dma_is_coherent() > > return for PowerPC? It seems right now that it returns false for > > devices that are DMA coherent, which seems to me to be a recipe for > > future mistakes. > > Perhaps implement the arch_setup_dma_ops() for PPC, that set > "dev->dma_coherent = true" could work? Only for coherent ops :) Cheers, Ben.