Hello Oliver, > There is no reason why we have to use the set_tone routine of the > stv0900. You can combine > - set_tone of LNBH24 with > - stv090x_send_diseqc_msg of stv0900 > without losing anything. > Before a DiSEqC message will be sent, the tone will be disabled. > Then the stv090x_send_diseqc_msg of the stv0900 can control the 22kHz > tone generator of the LNBH24 using EXTM or DSQIN. yes, you right. > > I think lnbp21_set_tone will be used if set_tone is not defined > > previously (set_tone == NULL). Is this correct ? > No, sorry. set_tone had to be added, because the stv0900 can also > operate in DiSEqC envelope mode (connected to DSQIN of the LNBH24). > In this mode set_tone of the LNBH24 has to be used. ok, you right. But seems like "fe->ops.set_tone = lnbp21_set_tone;" override ".set_tone = stv090x_set_tone," and stv090x_set_tone never used. Is this right ? Also please check our logic. We set override_clear=LNBH24_TEN in cx23885-dvb.c i.e. we disabling 22kHz logic in LNBH24 and all 22kHz logic driven from one place ( stv0900 ). This more clear for debugging (hardware and software ). This problem is reported by one of our customer. Your changeset 13673:75331e740f61 is broke 22khz tone functionality on our cards. We need to find compromise. Reverting the patch is not a problem ( in this case we need to remove override_clear=LNBH24_TEN). -- Abylai Ospan <aospan@xxxxxxxx> NetUP Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
