Re: [PULL] http://udev.netup.ru/hg/v4l-dvb-aospan-22fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Abylai Ospan wrote:
> Please pulll change:
> 
> http://udev.netup.ru/hg/v4l-dvb-aospan-22fix/
> 
> "22-kHz set_tone fix for NetUP Dual DVB-S2-CI card".

NAK.

> Description:
> 
> 22-kHz tone can be driven in two ways:
> 1. LNBH24 can produce 22kHz continuous tone when TEN=1 ( 22 KHz tone
> output is always activated ).
> 
> 2. LNBH24 can reproduce 22kHz tone timings from DSQIN or EXTM pin's when
> TEN=0. From LNBH24 datasheet:
> "In order to improve design flexibility an external tone input pin is
> available (EXTM). The EXTM is a Logic input pin which activates the 22
> kHz tone output, on the VoTX pin, by using the LNBH24 integrated tone
> generator (similar to the DSQIN pin function). In fact, the output tone
> waveform characteristics will always be internally controlled by the
> LNBH24 tone generator and the EXTM signal will be used as a timing
> control for DiSEqC tone data encoding on the VoTX output."
> 
> In NetUP Dual DVB-S2-CI card 22kHz tone timings on EXTM pin produced by
> STV0900 demod:
> .set_tone = stv0900_set_tone
> 
> redefine to "set_tone = lnbp21_set_tone" is not correct for "NetUP Dual
> DVB-S2-CI card".

Why is it not correct? Please explain.

Afaics it does not matter, whether the demod or the LNBH24 controls the
22kHz tone. With your patch, lnbp21_set_tone would never be used...

CU
Oliver

-- 
----------------------------------------------------------------
VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/
4 MByte Mod: http://www.escape-edv.de/endriss/dvb-mem-mod/
Full-TS Mod: http://www.escape-edv.de/endriss/dvb-full-ts-mod/
----------------------------------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux