Hi,
Abylai Ospan wrote:
> Hello Oliver,
>
> > There is no reason why we have to use the set_tone routine of the
> > stv0900. You can combine
> > - set_tone of LNBH24 with
> > - stv090x_send_diseqc_msg of stv0900
> > without losing anything.
> > Before a DiSEqC message will be sent, the tone will be disabled.
> > Then the stv090x_send_diseqc_msg of the stv0900 can control the 22kHz
> > tone generator of the LNBH24 using EXTM or DSQIN.
> yes, you right.
>
> > > I think lnbp21_set_tone will be used if set_tone is not defined
> > > previously (set_tone == NULL). Is this correct ?
> > No, sorry. set_tone had to be added, because the stv0900 can also
> > operate in DiSEqC envelope mode (connected to DSQIN of the LNBH24).
> > In this mode set_tone of the LNBH24 has to be used.
> ok, you right.
> But seems like "fe->ops.set_tone = lnbp21_set_tone;" override ".set_tone
> = stv090x_set_tone," and stv090x_set_tone never used. Is this right ?
Correct.
> Also please check our logic. We set override_clear=LNBH24_TEN in
> cx23885-dvb.c i.e. we disabling 22kHz logic in LNBH24 and all 22kHz
> logic driven from one place ( stv0900 ).
Well, if you specify override_clear=LNBH24_TEN then we have a problem.
Possible solutions:
a) Do not set LNBH24_TEN in override_clear, or
b) Modify your patch to something like that:
if (!(override_clear & LNBH24_TEN))
fe->ops.set_tone = lnbp21_set_tone;
Both will fix the issue.
> This more clear for debugging
> (hardware and software ).
> This problem is reported by one of our customer. Your changeset
> 13673:75331e740f61 is broke 22khz tone functionality on our cards.
Ok, I did not expect that someone would set LNBH24_TEN in
override_clear. ;-)
> We need to find compromise. Reverting the patch is not a problem ( in
> this case we need to remove override_clear=LNBH24_TEN).
No problem. Both solutions above are ok for me. Maybe b) is more robust,
because it allows override_clear=LNBH24_TEN to be used.
I leaveit to you: Choose the one you like.
Regards,
Oliver
--
----------------------------------------------------------------
VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/
4 MByte Mod: http://www.escape-edv.de/endriss/dvb-mem-mod/
Full-TS Mod: http://www.escape-edv.de/endriss/dvb-full-ts-mod/
----------------------------------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
