Hi, Abylai Ospan wrote: > > > redefine to "set_tone = lnbp21_set_tone" is not correct for "NetUP Dual > > > DVB-S2-CI card". > > > > Why is it not correct? Please explain. > > > > Afaics it does not matter, whether the demod or the LNBH24 controls the > > 22kHz tone. With your patch, lnbp21_set_tone would never be used... > > LNBH24 can _continuously_ produce 22kHz tone. This way acceptable if you > only want to switch LNB's oscillator to high band. > > If you want to send diseqc command you need to "modulate" this 22kHz > tone. LNBH24 can't do this but STV0900 demod can. There is no reason why we have to use the set_tone routine of the stv0900. You can combine - set_tone of LNBH24 with - stv090x_send_diseqc_msg of stv0900 without losing anything. Before a DiSEqC message will be sent, the tone will be disabled. Then the stv090x_send_diseqc_msg of the stv0900 can control the 22kHz tone generator of the LNBH24 using EXTM or DSQIN. > I have created some demonstration from oscilloscope on NetUP Dual > DVB-S2-CI card in attachment ( sorry, russian interface :). > Blue is a EXTM pin, yellow is a coaxial connector. As you can see > STV0900 sends 11 period's and LNBH24 reproduce it to coaxial output. > This is so colled "diseqc modulated mode". > Scheme of modulated signals you can find in diseqc bus specification - > http://www.eutelsat.com/satellites/pdf/Diseqc/Reference% > 20docs/bus_spec.pdf on "Figure 1: DiSEqC Modulation Scheme". See above. The 22kHz output of the LNBH24 is a logical 'or' of the TEN flag and the control inputs. I don't see any problem here. > I think lnbp21_set_tone will be used if set_tone is not defined > previously (set_tone == NULL). Is this correct ? No, sorry. set_tone had to be added, because the stv0900 can also operate in DiSEqC envelope mode (connected to DSQIN of the LNBH24). In this mode set_tone of the LNBH24 has to be used. When I modified the lnbp21 module, I considered both cases. I could not (and cannot) see any problem here. Please revert the patch. CU Oliver -- ---------------------------------------------------------------- VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/ 4 MByte Mod: http://www.escape-edv.de/endriss/dvb-mem-mod/ Full-TS Mod: http://www.escape-edv.de/endriss/dvb-full-ts-mod/ ---------------------------------------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html