Re: build warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 18, 2011 at 02:18, Michael Schmitz
<schmitzmic@xxxxxxxxxxxxxx> wrote:
On Tue, Jan 18, 2011 at 9:14 AM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
On Mon, Jan 17, 2011 at 20:50, Michael Schmitz
<schmitzmic@xxxxxxxxxxxxxx> wrote:
The only patch that has been missed, but may be relevant for Atari still:

16 bit FAT default for GEMDOS:

--- linux-m68k-git/linux-m68k/fs/fat/inode.c  Â2010-11-10
19:40:40.131506952 +1300
+++ linux-2.6-2.6.37/debian/build/source_m68k_none/fs/fat/inode.c
Â2011-01-17 20:18:44.484006839 +1300
@@ -923,10 +923,10 @@
   Â{Opt_err_cont, "errors=continue"},
   Â{Opt_err_panic, "errors=panic"},
   Â{Opt_err_ro, "errors=remount-ro"},
+ Â Â Â {Opt_discard, "discard"},
   Â{Opt_atari_yes, "atari=yes"},
   Â{Opt_atari_yes, "atari"},
   Â{Opt_atari_no, "atari=no"},
- Â Â Â {Opt_discard, "discard"},
   Â{Opt_obsolate, "conv=binary"},
   Â{Opt_obsolate, "conv=text"},
   Â{Opt_obsolate, "conv=auto"},

The order of the options shouldn't matter. Due to historical reasons,
it's different
on master and m68k-queue.

I thought the 'discard' marks the start of no longer used options
(i.e. option processing stops at discard). My bad.

You got me, I never looked at it that way ;-)

No, it comes from commit 681142f9211b23e6aa2984259d38b76d7bdc05a8
("fat: make discard a mount option")

I'd suggest I first test that this option is still required - will
have to sacrifice a spare SCSI disk for that.

I think there was a half consensus or so that we still need it, but
not enough to
put some weight behind it ;-)

Given that I could not even remember what it was that I had to do to
the FAT code to get it to what it does now, we best leave it at that.
Schroedingers cat, and all that :-)

commit cc9c5fc236c0d02cae44c2fbcc8ffa3ae5e517b6 ("Atari FAT updates")
more or less summarizes it. It's the logic which decides whether the FAT is
16-bit or 12-bit.

Gr{oetje,eeting}s,

            Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
             Â Â -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux