On Fri, 18 Dec 2009, Dmitry Torokhov wrote: > > > > > #define BTN_TRIGGER_HAPPY01 0x210 > > > > > ... > > > > > #define BTN_TRIGGER_HAPPY40 0x238 > > > > > > > > > > :-P Assuming 40 additional buttons should be crazy enough (but I know > > > > > this has been said before about other things). > > > > > > > > Dmitry, do you have any preference here yourself? > > > > > > "Trigger happy" sounds fine. > > > > OK, so how about something along the lines below? > > How about we move trigger happy further towards the 0x2ff limit? Sure, no problem. Just tell me the range you'd be comfortable with, and I'll apply a patch using that range. > Also, do we clamp the bit numbers at KEY_MAX? Good point. I'll update all the map_*() macros in a separate patch and add range overflow checks. > Otherwise looks good, please push through your tree. Thanks, -- Jiri Kosina SUSE Labs, Novell Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html