Hi Dmitry,
I am working on the 3M driver and taking your comments into account
(and applying them to the Stantum driver as well) but I have an
question on the comment below:
+struct mmm_finger {
+ __s32 x, y;
+ __u8 rank;
+ int touch:1, valid:1;
+};
Does it make sense to turn access to touch and valid into
read-modify-write sequence? Just change them to be 'bool's, it won't
cause your structures to grow in size.
+struct mmm_data {
+ struct mmm_finger f[10];
+ __u8 curid, num;
+ int touch:1, valid:1;
Same as above.
Why do you think a read-modify-write sequence would be better? in my
mind these were just cached values, just like x and y.
Cheers,
St.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
