On Thu, Oct 29, 2020 at 03:50:25PM +0000, Jonathan Cameron wrote: > On Wed, 28 Oct 2020 21:31:40 +0100 Lukas Wunner <lukas@xxxxxxxxx> wrote: > > On Sun, Oct 11, 2020 at 06:07:36PM +0100, Jonathan Cameron wrote: > > > +examples: > > > + - | > > > + spi { > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + dac@0 { > > > + compatible = "ti,dac082s085"; > > > + reg = <0>; > > > + spi-max-frequency = <40000000>; > > > + spi-cpol; > > > + spi-cpha; > > > + vref-supply = <&vref_2v5_reg>; > > > + }; > > > + }; > > > > Hm, why wasn't the "vref_2v5_reg" node carried over from the txt file? > > Showing how to supply a regulator isn't generally necessary in an example. > I don't mind having it there though so can keep it > (as the fixed regulator binding has been converted to yaml) The "vref_2v5_reg" node is referenced by the "dac@0" node, so I included it in the example for completeness. I'd appreciate if it could be carried over to the YAML file, unless its inclusion is a bad practice. Thanks, Lukas