On Wed, 28 Oct 2020 21:31:40 +0100 Lukas Wunner <lukas@xxxxxxxxx> wrote: > On Sun, Oct 11, 2020 at 06:07:36PM +0100, Jonathan Cameron wrote: > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/dac/ti,dac082s085.yaml > > @@ -0,0 +1,58 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/iio/dac/ti,dac082s085.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Texas Instruments DAC082s085 and similar DACs > > + > > +description: > > + A familly of Texas Instruments 8/10/12-bit 2/4-channel DACs > ^^ > s/familly/family > > > > + spi-cpha: true > > + spi-cpol: > > + description: > > + Should be either spi-cpha, or spi-cpol but not both. > > + > > + vref-supply: true > [...] > > +required: > > + - compatible > > + - reg > > "vref-supply" and ("spi-cpha" xor "spi-cpol") are also requird > per the existing txt file. I have no idea how to specify the spi-cpha xor spi-cpol unfortunately. Have a question out to Rob on that one. vref-supply was a stupid mistake from me. Will fix. > > > > +examples: > > + - | > > + spi { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + dac@0 { > > + compatible = "ti,dac082s085"; > > + reg = <0>; > > + spi-max-frequency = <40000000>; > > + spi-cpol; > > + spi-cpha; > > + vref-supply = <&vref_2v5_reg>; > > + }; > > + }; > > Hm, why wasn't the "vref_2v5_reg" node carried over from the txt file? Showing how to supply a regulator isn't generally necessary in an example. I don't mind having it there though so can keep it (as the fixed regulator binding has been converted to yaml) > > Thanks, > > Lukas
