On Thu, Oct 29, 2020 at 5:26 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > > On Mon, 26 Oct 2020 20:05:15 +0200 > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > > This makes the driver code slightly easier to read. > > > > Cc: Eddie James <eajames@xxxxxxxxxxxxx> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > Hi Andy, > > I am a bit in 2 minds about this one. > > I'm not 100% sure on the register arrangement here, but it 'looks' like > a be64 followed by some smaller registers. > It isn't documented like that in the datasheet though, so representing > it as such might confuse people... > > So, we 'could' use a structure with a __be64 and some __be16s then all > would be aligned, but it would be hard to align with the datasheet. > > Unfortunately what you have here is also rather hard to align with > the datasheet... Thanks for the review. I just got it right now that the proper one (and for previous similar patch) should be converting to the bitmap API. Because it seems to me that there are fields from a bigger bitmap area. However, I might be mistaken. I will drop this from my local branch. -- With Best Regards, Andy Shevchenko
