On Thu, Apr 01, 2010 at 03:37:47PM +0900, Tejun Heo wrote: > > It was the asymmetry between the two paths that bothered me and made > me think there should be something else wrong. So, the problem is > ide_dma_timeout_retry(), which is used only by ide_timer_expiry(), > clearing hwif->rq, right? Then, wouldn't not clearing hwif->rq in > ide_dma_timeout_retry() a better solution? I don't think that works. We want to requeue regardless of whether we return ide_stopped. If you don't clear hwif->rq and rely on the parent to do it then it'll only requeue when we return ide_stopped. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
