On Thu, Apr 01, 2010 at 03:25:50PM +0900, Tejun Heo wrote: > > In ide_timer_expiry() if drive->waiting_for_dma is false, ide_error() > is called, which in turn calls __ide_error() for fs requests. > ide_ata_error() will be called if the device is a disk. If the > request hasn't reached the retry limit and reset is not necessary, > ide_ata_error() will return ide_stopped without requeueing the > request. ide_timer_expiry() will clear hwif->rq without requeueing > the request and the request will be lost. No? It shouldn't be lost in that case because of the rq_in_flight thing that you added will catch it and requeue. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
