On Thu, Apr 01, 2010 at 01:56:53PM +0900, Tejun Heo wrote: > > OIC. It's also cleared in ide_timer_expiry() too. Asymmetry among > different failure paths worries me. e.g. looking at the code, I can't > find how ide_error() would requeue the request either. It looks like > each hwif->rq = NULL in failure path should be investigated and the > affected ones should be replaced with a function which requeues and > clears hwif->rq. Hmmm.... am I misunderstanding something? I had a look at the rest of them and they seemed to be fine. So are you OK for this patch to go in? Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
