Hello, On 04/01/2010 03:32 PM, Herbert Xu wrote: >> ide_timer_expiry() will clear hwif->rq without requeueing >> the request and the request will be lost. No? > > It shouldn't be lost in that case because of the rq_in_flight > thing that you added will catch it and requeue. I feel pretty stupid now. Thanks for enlightening me on how the code I added works. :-) It was the asymmetry between the two paths that bothered me and made me think there should be something else wrong. So, the problem is ide_dma_timeout_retry(), which is used only by ide_timer_expiry(), clearing hwif->rq, right? Then, wouldn't not clearing hwif->rq in ide_dma_timeout_retry() a better solution? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
