Re: [PATCH] Re: 2.6.17-rc5-git1: regression: resume from suspend(RAM) fails: libata issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Sat, 27 May 2006, Jeff Garzik wrote:
>
> Linus Torvalds wrote:
> > 	u8 status = ata_wait_idle(ap);
> 
> Vastly decreased wait probably won't work, since we had to increase the wait
> otherwise.
> 
> > 	if (!ata_ok(status))
> 
> Correct (re DRQ etc.).

I actually just want to see what the bits are here.

In other words, we already have a good solution for Mark's problem. I 
don't think the suggested solution on top of that for Jens is any good, 
and I'd like to see what bits are set for Jens here.

So I _expect_ (or rather, hope) it to fail for his setup. 

Jens doesn't seem to have the ATA_BUSY bit set, because if he did, then 
the ata_busy_wait() thing should basically have done the wait for him. 

That's why I did the wait-idle() + ata_ok() check. It should all work 
beautifully on machines that didn't have trouble before - but it should 
hopefully print out something interesting for machines that are potential 
trouble-spots.

			Linus
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux