Re: [PATCH] Re: 2.6.17-rc5-git1: regression: resume from suspend(RAM) fails: libata issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mark Lord wrote:
Jeff Garzik wrote:
Jens Axboe wrote:
On Sat, May 27 2006, Jeff Garzik wrote:
+    msleep(500);
    pci_set_power_state(pdev, PCI_D0);
    pci_restore_state(pdev);
    pci_enable_device(pdev);
Does it work if you move msleep() below pci_restore_state()?
"    "     "    "      below pci_enable_device()?

Placement makes no difference here, it works after pci_enable_device()
as well. What matters is the delay coming before the ata_busy_wait().
You could just stuff it in front of that, if you wanted.

That would increase the wait needlessly, since it would be then done per-device, even though the devices spin up in parallel on ata_piix.

Okay, so 2/3 of use have working machines again now.

How is your beast doing with this tweak, Jeff?

I think my beast needs full controller init, the new patch still hardlocks. Ignore it for 2.6.17 I think...

	Jeff



-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux