Re: [PATCH v2] Revert "i2c: rcar: remove spinlock"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/02/2014 09:18 PM, Wolfram Sang wrote:

As I understood from your previous mail, a plain revert is less broken
but still broken. Applying a correct fix is my preferred way.

    Actually, from the -stable kernel perspective, a single patch would
complicate backporting. So could you please reconsider?

I don't see why. If we have two patches, the state inbetween them is
broken.

Even so, it has always been broken, we don't make it more broken by reverting your change.

And we don't have two patches yet, just the revert. So, the

I'm going to consider the spinlock issue ASAP, after I check whether the I2C clock frequency really has any influence on the unexpected read NACK issue I've been chasing for several days.

result is broken anyhow.

Can you elaborate?

Your patch removing the spinlock went into 3.16 only but we'd have to backport the assumed single patch to the -stable kernels older than that. This means that I'd have to provide the "delta" patch (i.e. the separate patch that I'd like to provide now atop of the revert) for these kernels instead since the original single patch wouldn't apply anyway.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux