On Fri, Oct 2, 2009 at 12:37 AM, Wolfram Sang <w.sang@xxxxxxxxxxxxxx> wrote: >> > Ah, so 'make the driver work on i.MX51' is a good statement which should >> > be part of the commit message. >> Well, maybe I can mention it. >> But I think the good point is to present what you modified, not the side effect. > > It is not the side effect but the intention :) As no code is changed without a > need, the reason really should be in the patch description. No, it's not intention. I'm just trying to make the controller work in a right way. Without this patch, maybe some other fast cpus have problem too. I just tested mx31 and mx51. I will add "Without this patch, i2c on some fast SoCs (for example imx51) will not work". Is it ok for you? > >> Yes. But I don't have multi-master system. So I can't say that. >> The code is just taken from Freescale latest code. Without it, It >> could also cause a device error. I forget the details. Anyway, it >> doesn't make anything wrong. > > Do you know where the details are explained? No, I don't. I don't have device in hand now. If you have, could you please help do a simple test? Use hw to simulate multi-master system. Before execute xfer, you first pull down SDA, then pull down SDC. It simulates a START. and execute xfer to see whether IBB is set? Thanks Richard > > Regards, > > Wolfram > > -- > Pengutronix e.K. | Wolfram Sang | > Industrial Linux Solutions | http://www.pengutronix.de/ | > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.9 (GNU/Linux) > > iEYEARECAAYFAkrE2uEACgkQD27XaX1/VRumZQCeL4x9oaBKKjSKzJLlRrkfvvqg > nlEAoLpQdpI3TeKEvK13rs46kSZRDsZU > =7kM6 > -----END PGP SIGNATURE----- > > -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
