On Sun, May 31, 2009 at 08:23:45AM +0300, Baruch Siach wrote:
> Hi Linus,
>
> On Thu, May 28, 2009 at 09:32:37AM +0200, Linus Walleij wrote:
> > 2009/5/28 Baruch Siach <baruch@xxxxxxxxxx>:
> >
> > >> > +static int dw_i2c_probe(struct platform_device *pdev)
> > >>
> > >> Can you tag this with __init?
> > >
> > > OK. __devinit is probably better.
> >
> > I don't think any platform_device tagged with __devinit is
> > correct really, platform_device:s cannot be hotplugged that's
> > against the definition of a platform_device.
I disagree, just beucase they aren't in general doesn't mean they
cannot be. I have been looking at an implementation which uses
hotplug to generate devices from a board description file.
It also makes life difficult if you want to unbind/bind device via
sysfs. basically, __devinit and __devexit, are in my view the correct
things to use here.
> Doesn't this __devinit have something to do with the ability to compile the
> driver as a module (as is the case here)? See for example
> drivers/watchdog/omap_wdt.c and commit
> 0e3912c75f42986c17d955542247bf04c6eef738
This is an example where __devinit/_devexit are being used proplerly.
> > I should make more cleanup patches regarding this...
>
> baruch
>
> --
> ~. .~ Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
> - baruch@xxxxxxxxxx - tel: +972.2.679.5364, http://www.tkos.co.il -
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Ben (ben@xxxxxxxxx, http://www.fluff.org/)
'a smiley only costs 4 bytes'
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
